Application navbar

[NayHtetKyaw]

it doesn't look good, so pls criticize

[chinathaip]

A non-frontend dev is about to review your code, be prepared!!! XDDD

[chinathaip]

(optional) can you also rebase your branch onto main? (idk if it's just me, but I feel the branches do get messy from git merge compared to git rebase)

[Lxkas]

I don't have my main pc right now xd and still have 3 midterms left, will work on this in a bit

[chinathaip]

I don't have my main pc right now xd and still have 3 midterms left, will work on this in a bit

Maybe work on it and comment it here? Just so we all know how you did it

[NayHtetKyaw]

I don't have my main pc right now xd and still have 3 midterms left, will work on this in a bit

Maybe work on it and comment it here? Just so we all know how you did it

i agreed, i will fix what i can

[Lxkas]

I don't have my main pc right now xd and still have 3 midterms left, will work on this in a bit

Maybe work on it and comment it here? Just so we all know how you did it

i agreed, i will fix what i can

Sure, fix what you can and I will work on it, I got my PC back now 😊

[chinathaip]

I don't have my main pc right now xd and still have 3 midterms left, will work on this in a bit

Maybe work on it and comment it here? Just so we all know how you did it

i agreed, i will fix what i can

Sure, fix what you can and I will work on it, I got my PC back now 😊

Coolio, well done guys @Lxkas @NayHtetKyaw

Keep me updated too

[Lxkas]

pls, like I said, use the NavLink component so you don't have to manage active state manually, along with making a lot of things easier:

• link highlight using pathname from the router
• a built-in onclose optional callback
• tab navigation (a11y)
• keyboard interactions, i.e. space for open
• screen-reader support (a11y)
• nested links with a customizable chevron or whatever icon
• auto "list item" styling
• keeping it on-theme

👏I beg, use NavLink, you can even remove the onclose callback from the type def, or make it optional

@NayHtetKyaw

[NayHtetKyaw]

pls, like I said, use the NavLink component so you don't have to manage active state manually, along with making a lot of things easier:

* link highlight using pathname from the [router](https://nextjs.org/docs/pages/api-reference/functions/use-router)

* a built-in onclose optional callback

* tab navigation (a11y)

* keyboard interactions, i.e. space for open

* screen-reader support (a11y)

* nested links with a customizable chevron or whatever icon

* auto "list item" styling

* keeping it on-theme

👏I beg, use NavLink, you can even remove the onclose callback from the type def, or make it optional

@NayHtetKyaw

Okay okay, i thought it was optional. I'll try to change it then. I am not familiar with NavLink, that's why i avoided it. !

[chinathaip]

Coolio, well done guys. Thank you Mr Tawan and Anascence. Very excited for this to get merged!

[chinathaip]

closes https://github.com/stamford-syntax-club/stamfordcenter-frontend/issues/30

[Lxkas]

There are a couple of problems now:

• NavLinkWithDropdown
• NormalNavLink

Both of these in ApplicationHeader.tsx will have to be re-made so that they're more ergonomic to use, and support multi-level dropdowns.

I've refactored the codebase a bunch, and the mobile navbar is now essentially complete, with multi-level dropdown support, now it's just the desktop stuff that needs another once-over.

[Lxkas]

@NayHtetKyaw also, please tell me why you added react-router-dom ty.

[NayHtetKyaw]

@NayHtetKyaw also, please tell me why you added react-router-dom ty.

we don't need it, i added by accident, though navlink was from react

[chinathaip]

@NayHtetKyaw also, please tell me why you added react-router-dom ty.

we don't need it, i added by accident, though navlink was from react

Aight, I'm gonna remove it and rebase again alright? The commits are all over the place - it'll be a mess when merging back to main @Lxkas @NayHtetKyaw

[NayHtetKyaw]

so i guess the mobile navbar is done now ?

[Lxkas]

so i guess the mobile navbar is done now ?

Yes, the mobile navigation is done but it also broke the normal navigation on desktop, when it's fixed, this can be merged 👍