search

stamparm / ipsum

Daily feed of bad IPs (with blacklist hit scores)
The Unlicense
1.51k stars 136 forks source link

Commit history #53

Closed randommen96 closed 3 months ago

randommen96 commented 3 months ago

Hi,

I noticed that the commit history is wiped everytime a new commit is pushed to master, this disables the abillity to review changes in the past, causing possible issues.

Would it be possible to keep the commit history instead of rewriting it everytime?

stamparm commented 3 months ago

nope, because it would result with huge commit history. already tried

On Wed, Jun 12, 2024, 10:20 David der Nederlanden @.***> wrote:

Hi,

I noticed that the commit history is wiped everytime a new commit is pushed to master, this disables the abillity to review changes in the past, causing possible issues.

Would it be possible to keep the commit history instead of rewriting it everytime?

— Reply to this email directly, view it on GitHub https://github.com/stamparm/ipsum/issues/53, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHA7U3F5ZN3DZ5KTKDPGDLZHAAGHAVCNFSM6AAAAABJF25NROVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2DQMJTGM4DIMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

randommen96 commented 3 months ago

Out of curiosity, what kind of issues did you experience with a huge commit history?

stamparm commented 3 months ago

https://github.com/stamparm/ipsum/issues/6

Basically, git history grew at such pace, that after some time (AFAIR, it was after couple of weeks or smth) I had to switch to Git LFS. Then, quickly, quota would be used quickly by all the pulls.

image

image

stamparm commented 3 months ago

I hope that you all realize that the IP list changes are dramatic at each update (filling the Git history). It is not like programming couple of lines of code and pushing the changes

randommen96 commented 3 months ago

I understand!

So the git history grew outrageous in a short period of time.

Makes me wonder, would squashing the commits once in a while be a solution? It would take some scripting in the automated pushing, but I think it can work?