stampchain-io / BTCStampsExplorer

Bitcoin Stamps API / Explorer
https://bitcoinstamps.xyz
GNU Affero General Public License v3.0
4 stars 6 forks source link

Image sharpening in home page thumbs #167

Open arwyn6969 opened 1 month ago

arwyn6969 commented 1 month ago

Page shows collections not updated for nearest about scaling specifically on recursive collections and featured collections

Note looks like prunes stones and the avime ones render ok

image

reinamora137 commented 1 month ago

Also need to add the usual placeholder image when an image isn’t rendering on a collection. Right now this pulls the first image in the collection which may be a deploy without an image so it may take some updates on the indexer to determine if it’s a valid image and link to another one. That will be an issue for the indexer repo but we should be using the not available image when not rendering anyway.

reinamora137 commented 1 month ago

Appears to be a rendering problem of the src-721 svg’s mostly on iOS mobile in the stampcard. May need a specific container for svg’s to resolve

reinamora137 commented 1 month ago

image #3 and #4 in the row of 4 above (and in the collection) are SVG's they should not be blurry.

Also the broken image ? should be rendered with the placeholder image.

reinamora137 commented 1 month ago

placeholder image for not-available added here

https://github.com/stampchain-io/BTCStampsExplorer/pull/239/files

reinamora137 commented 1 month ago

SVG images still showing as blurry. And the placeholder image doesn't appear to be fully implemented

Image

wichopy commented 2 weeks ago

ill look at this one

reinamora137 commented 2 weeks ago

thanks. as mentioned this is pretty specific to src-721 images on ios.

with the exception of the ? unrenderable SVG -- this is a botched up svg coming from the indexer - that's probably easier to fix there, but if you see a simple solution to detect and even remove those from displaying that's cool.

the main priority is the blurry svg's on ios mobile. (which we could also change how those svg's are built on the indexer if needed).