Holders component / Pie chart

stampchain-io / BTCStampsExplorer

Bitcoin Stamps API / Explorer

https://bitcoinstamps.xyz

GNU Affero General Public License v3.0

4 stars 6 forks source link

Holders component / Pie chart #404

Closed babalicious-io closed 1 day ago

babalicious-io commented 3 days ago

Screenshot 2024-11-29 at 23 27 57

Screenshot 2024-11-29 at 23 27 44

Holders table needs some finetuning

placement is perfect without scrollbar
when scrollbar is displayed then it (and scrollbar) should shift a little left (pr-6 kind of thing)
can the scrollbar be moved down a little (mt-6/pt-6)

HoldersGraph.tsx

The pie chart

the tooltips aren't displayed - should display addy on hover
animate on load

PieChart.tsx GitHub doc

wichopy commented 2 days ago

is it just me? I am seeing an overlap of the text when growing the screen.

https://github.com/user-attachments/assets/49289dc3-a67f-4436-a716-54055ce695dc

wichopy commented 2 days ago

potential fix, please try it out.

https://github.com/stampchain-io/BTCStampsExplorer/pull/410

wichopy commented 1 day ago

for holders table, adding tooltip

https://github.com/stampchain-io/BTCStampsExplorer/pull/412

I thought we could jus use the tailwind auto layout for the table, which removes the need for abbreviating, but feel free to give feedback if thats what we want. I figured if we want a tool tip to show the whole address, why not just show the whole address when you have enough screen real estate?

reinamora137 commented 1 day ago

looks good now! closing this one