stampit-org / react-stamp

Composables for React.
370 stars 10 forks source link

remove carret on stamp-utils version #36

Closed amelon closed 8 years ago

amelon commented 8 years ago

Hello,

i've spent hours to figure out what's wrong with my react project and it appears that react-stamp is incompatible with stamp-utils 1.3.1 (or maybe 1.3.1 has bug)

Actually, with this simple component,

const C = reactStamp(React).compose({
  render() {
    return <div>My react stamp component</div>
  }
})

the compose method remove render because stamp-utils.isDescriptor({ render() {...} }) return true with version 1.3.1 but not with version 1.2.4.

Could you please change carret with tilde on stamp-utils to avoid to use 1.3.1 version ?

  "dependencies": {
    "lodash": "^4.6.1",
    "stamp-utils": "~1.2.4"
  },
ericelliott commented 8 years ago

Removing the tilde is a good idea, but why not update react-stamp to work with the latest version?

amelon commented 8 years ago

Thanks for the quick fix.

troutowicz commented 8 years ago

Will push a new release as soon as I can.

ericelliott commented 8 years ago

Cool. Thanks. =)