search

stampit-org / react-stamp

Composables for React.
370 stars 10 forks source link

upgrade stamp-utils and related code + unit tests #41

Closed cchamberlain closed 7 years ago

cchamberlain commented 7 years ago

I found the places that broke between stamp-utils versions 1.2.4 and the current 1.3.2 and wrote a couple unit tests around the code that changed. The thing that broke it all is stamp-utils changing isDescriptor checking specific descriptor properties to now just using lodash isObject.

As I am not familiar with the stamp-utils descriptor spec change, the simplest fix was to include the descriptor names here and check them.

cchamberlain commented 7 years ago

Fixes https://github.com/stampit-org/react-stamp/issues/36

ericelliott commented 7 years ago

What exactly broke? The stamp-utils isDescriptor is correct behavior according to the specification.

ericelliott commented 7 years ago

Ping @troutowicz

troutowicz commented 7 years ago

Taking a look.

troutowicz commented 7 years ago

Please remove the yarn lock file.

Edit: Also remove the dist builds, I will create before publishing a new version.

cchamberlain commented 7 years ago

Requests complete, please let me know if I missed anything.

troutowicz commented 7 years ago

Please add back the dist files from the master branch.

troutowicz commented 7 years ago

Looks good :+1: