search

stampit-org / stamp-specification

The Stamp Specification: Composables
434 stars 16 forks source link

[WIP] Use deepmerge instead of lodash.mergeWith #100

Closed danielkcz closed 8 years ago

danielkcz commented 8 years ago

Closes #94

danielkcz commented 8 years ago

It's good we have tests :) Obviously that library is missing something since tests are failing. I'll investigate later.

koresar commented 8 years ago

The lodash deep merges to the first argument. Whereas this implementation does not, instead it creates and returns a new object. 💩

koresar commented 8 years ago

The work done here was migrated to stampit module. This compose implementation does not need to be tiny or performant because it serves as an example only.

Cheers!