getter/setter cannot run

stampit-org / stamp-specification

The Stamp Specification: Composables

434 stars 16 forks source link

getter/setter cannot run #125

Closed lornally closed 4 years ago

lornally commented 5 years ago

i will fix it, now

lornally commented 5 years ago

you are welcome. cool, we have propertyDescriptors, and actually, we have it in stampit, do we replace it in stampit? and ask a digression from this issue, how can you react so in time? you can receive some github message?

koresar commented 5 years ago

Maybe Stamps should support getters and setters out of the box for every metadata. I've created this Request For Comments issue: https://github.com/stampit-org/stamp-specification/issues/127

I'm willing to implement it consistently.

With full unit test coverage via check-compose
In stamp-specification (it's a example implementation), stampit (most used module) and @ stamp/it

lornally commented 5 years ago

i agree with you, i think getter/setter is a base require. and i think now stamp-specification is not a really specification, because it is not simple enough, it is so complex and more long-winded than stampit.