search

stampit-org / stamp-specification

The Stamp Specification: Composables
434 stars 16 forks source link

Shared (protected) state implementation #85

Closed koresar closed 8 years ago

koresar commented 8 years ago

Implements #84

ericelliott commented 8 years ago

I am very opposed to this PR. Sharing "private" state between stamps tightly couples those stamps to private implementations of other stamps. If you feel the need to do that, you may be thinking too much in terms of classical inheritance and not enough in terms of isolated components. If stamps need shared access to something, it's probably better to share it through a public API.

koresar commented 8 years ago

@ericelliott let's discuss the proposal in #84 See my answer there.

koresar commented 8 years ago

Per discussion in #84 this PR should be closed. The functionality is considered not necessary or even harmful.