search

stampit-org / stamp-utils

Stamp utilities
MIT License
44 stars 2 forks source link

File structure simplification #5

Closed koresar closed 8 years ago

koresar commented 8 years ago

I found it hard to follow the proposed file structure for the set on one-liner functions. This PR simplifies the project structure.

Also, this implements the stampit-org/stamp-specification#59 terminology.

unstoppablecarl commented 8 years ago

I think these should also be clearly defined in the stamp-specification. In the readme we should have a clear explanation of what each object is and what is tested for like the code below.

const isDescriptor = obj => isObject(obj);
const isStamp = obj => isFunction(obj) && isFunction(obj.compose) && isDescriptor(obj.compose);
const isComposable = obj => isDescriptor(obj) || isStamp(obj);

Looks good :+1:

koresar commented 8 years ago

There was a clarification PR about a month ago @unstoppablecarl. See https://github.com/stampit-org/stamp-specification/pull/60

If you feel it should be improved in any way - please suggest. Thanks :)

ericelliott commented 8 years ago

I use a debug script with iron-node. See this example. (Note: those are two different links. =)

koresar commented 8 years ago

Nice! One more file in /test directory is okay I believe. If I were you I'd add a comment to this file saying something like "// this is used only for unit test debugging with iron-node

Otherwise people might want to delete it unintentionally ☺