search

stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

add @stamp/eventemittable, a composable EventEmitter #26

Closed boneskull closed 7 years ago

boneskull commented 7 years ago

note to self: don't press the "Update Branch" button unless you want to sort out a merge commit

boneskull commented 7 years ago

diagnosing failures

koresar commented 7 years ago

Btw, you could have created branch right in the https://github.com/stampit-org/stamp repo. No need to fork it.

koresar commented 7 years ago

Superseded with #27

boneskull commented 7 years ago

I ended up creating a getMaxListeners() function since the events module doesn't support it. I should probably change it to be optional, if in the future, that module adds support.

This method was added during the iojs days, so it's been around for awhile.

koresar commented 7 years ago

Good point. It's better be added to the events module though.

On Thu, 4 May 2017, 04:00 Christopher Hiller notifications@github.com wrote:

I ended up creating a getMaxListeners() function since the events module doesn't support it. I should probably change it to be optional, if in the future, that module adds support.

This method was added during the iojs days, so it's been around for awhile.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/stampit-org/stamp/pull/26#issuecomment-298988144, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjCL7bLSMEm9RLA69wCeZK1rvggEPIWks5r2MCjgaJpZM4NPDLp .