stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

Update jest to version 20.0.0 ๐Ÿš€ #28

Closed greenkeeperio-bot closed 7 years ago

greenkeeperio-bot commented 7 years ago
๐Ÿšจ๐Ÿ”ฅโš ๏ธ Action required: Switch to the new Greenkeeper now! ๐Ÿšจ๐Ÿ”ฅโš ๏ธ
This version of Greenkeper will be shutdown on May 31st.
With Integrations first-class bot support landed on GitHub and weโ€™ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.


Hello lovely humans,

jest just published its new version 20.0.0.

State Update :rocket:
Dependency jest
New version 20.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of jest. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isnโ€™t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while Iโ€™m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project :sparkles:

You rock!

:palm_tree:

danielkcz commented 7 years ago

@koresar Might be a good idea to actually switch to the greenkeeper bot instead. I don't have rights for that.

koresar commented 7 years ago

I switched off GK for this repo. Can't understand why it's here! Will take a look at timing morning (in 8 hours).

danielkcz commented 7 years ago

Hm, you hate Greenkeeper for some reason that you don't want to use it?

koresar commented 7 years ago

I don't hate GK. It have just flooded all the repos with

danielkcz commented 7 years ago

I see. Well, it's either that or go through your projects occasionally and do manual updates. In the end, it would probably waste even more time to do it like that. Unless of course, you don't care about projects staying up to date with possible fixes and improvements.

From my experience, they have really improved the problem with branches that haven't got any PR created.

koresar commented 7 years ago

True. I'll turn it back on after the previous version of the GK expires. Ok?

On Sun, 7 May 2017, 21:33 Daniel K. notifications@github.com wrote:

I see. Well, it's either that or go through your projects occasionally and do manual updates. In the end, it would probably waste even more time to do it like that. Unless of course, you don't care about projects staying up to date with possible fixes and improvements.

From my experience, they have really improved the problem with branches that haven't got any PR created.

โ€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/stampit-org/stamp/pull/28#issuecomment-299699987, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjCL5AWn7tCAu-VOXyzztnUrGzIfGtMks5r3av2gaJpZM4NSvya .

danielkcz commented 7 years ago

It's fine by me. Not sure why to wait if this version is only causing a pain :) Your call.

koresar commented 7 years ago

This pr should have never existed because the GK is off in the repo and the stampit-org for few weeks now. Wtf GK? Why you still loitering around? ๐Ÿ˜

That's why I want to wait. It too buggy atm.

On Sun, 7 May 2017, 21:46 Daniel K. notifications@github.com wrote:

It's fine by me. Not sure why to wait if this version is only causing a pain :) Your call.

โ€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/stampit-org/stamp/pull/28#issuecomment-299700763, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjCL17UDNChcOAUn79iL02j-fvRn0YDks5r3a8JgaJpZM4NSvya .

danielkcz commented 7 years ago

Well, I assume it's buggy because it's a previous iteration of a whole solution. They are using this native GitHub bots now. Up to you.