search

stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

[Fixes #35] DEPRECATION constructor/of broken #36

Closed ericelliott closed 7 years ago

ericelliott commented 7 years ago

See #35

koresar commented 7 years ago

First question. Why the name of the PR states DEPRECATION? What are you deprecating?

koresar commented 7 years ago

This repo does not do package lock (yet). We might need it in the future. As soon as it is needed I'll add package-lock files to every package. Please, remove the file.

ericelliott commented 7 years ago

First question. Why the name of the PR states DEPRECATION? What are you deprecating?

Stamp.constructor was created in error. That was never the intended behavior. It's being deprecated in favor of Stamp.of. The .constructor property is an instance prototype property.

This repo does not do package lock (yet). We might need it in the future. As soon as it is needed I'll add package-lock files to every package. Please, remove the file.

Sure. We'll need to add it to .gitignore -- latest npm adds the lock file automatically.

koresar commented 7 years ago

Thanks! Looks good. TIL:

One key detail about package-lock.json is that it cannot be published

After publishing this package the README will become untrue. Could you please update it the way you see it?

ericelliott commented 7 years ago

Check the docs. Lots more detail on why this package is useful. =)

koresar commented 7 years ago

I wish I had this kind of writing talent 👍

koresar commented 7 years ago

I'm going to publish as v0.2.

In few days I'm going to publish all the packages as v1.0. This one included. Will remove the deprecated function.

koresar commented 7 years ago

v0.2 published: https://www.npmjs.com/package/@stamp/fp-constructor

koresar commented 7 years ago

I'd be very happy to see how you use this package. A blog post, or a repo link would be fine. I'm very interested.

ericelliott commented 7 years ago

Start with Functors and categories