Modernize - Githubissues

stampit-org / stamp

Stamps - better OOP model

https://stampit.js.org

MIT License

25 stars 3 forks source link

Modernize #41

Closed koresar closed 6 years ago

koresar commented 6 years ago

The author of the PR is @tkvw.

Added rollup for exporting umd and minified builds.
Moved sources to separate src folder.
Changed some tests to be compatible with the /src/ folder.

koresar commented 6 years ago

@tkvw I forgot what we were talking about two days ago. Could you please remind me what problem we are solving?

tkvw commented 6 years ago

For prototyping online (for example codepen), there's need for exported browser compatible builds. This PR adds the possibility to express dist:{umd:'<exportname>.js',minified:'<exportname>.min.js'} in the package.json and it will be published as so.

An 'all' package is added for exporting all functions in the stamp family.

But I see failing tests in travis, will look at it later

koresar commented 6 years ago

Ah, yes! Thank you! I'd need to do some minor changes to the all package exports to follow this repo standards. Also, I'd need to add a full README to it.

Thanks! Waiting for further commits. 👍

koresar commented 6 years ago

Since this PR destination branch is modernize I'll merge it and will create a new modernize -> master PR. Also, @tkvw I'll give you the write access to this repo. Please don't push to master :)