stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

Fix `@stamp/core/mergeOne()` not correctly handling properties with the value `undefined` #56

Closed PopGoesTheWza closed 4 years ago

PopGoesTheWza commented 4 years ago

Current implementation of @stamp/core/mergeOne() when hitting an src property with the value undefined simply returns (thus returning a final merged result of undefined. Code should be altered so that it continues the loop and compute the correct merged result.

This issue relates with #52

koresar commented 4 years ago

Can't find what you mean in the stamp/packages/collision/index.js:30 file.

PopGoesTheWza commented 4 years ago

@koresar I likely fumbled with the reference with/in collision.

Fact is you already have the fix identified (changing return to continue in mergeOne()

koresar commented 4 years ago

Then closing this issue as (soon to be) Done