search

stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

assign() to accept multiple args. merge() to not be called with undefined #60

Closed koresar closed 4 years ago

koresar commented 4 years ago

Fixes #52 #54

@PopGoesTheWza Here is a PR for your review (and hopefully merge).

koresar commented 4 years ago

Ok. Travis failed because Lerna is misbehaving in node 8, 10, 12. Other node version are fine. :( ffs

PopGoesTheWza commented 4 years ago

Ok. Travis failed because Lerna is misbehaving in node 8, 10, 12. Other node version are fine. :( ffs

Travis says: cipm can only install packages with an existing package-lock.json or npm-shrinkwrap.json

Hand him over your package-lock.json and he'll give you a green smile

koresar commented 4 years ago

Added the package-lock(s) back. Also changed the list of node.js for Travis: 8, 10, 12. 🤞

koresar commented 4 years ago

Omg. It worked. :)

PopGoesTheWza commented 4 years ago

Go green