search

stampit-org / stamp

Stamps - better OOP model
https://stampit.js.org
MIT License
25 stars 3 forks source link

Bump lerna to 6.x and typescript to 4.x #83

Closed sammys closed 1 year ago

sammys commented 1 year ago

This is task 1 from #356

koresar commented 1 year ago

Thanks! Awesomesause :)

I trust your judgements, so I skipped reviewing all the 37 files and 40,000 lines. :)

Would it help if I give you more privileged access to this project?

sammys commented 1 year ago

Thanks! Awesomesause :)

I trust your judgements, so I skipped reviewing all the 37 files and 40,000 lines. :)

In this case I'd say that was a wise choice hehe. It was predominantly TS compiling differently and maybe even eslint reformatting everything.

Would it help if I give you more privileged access to this project?

Might save you from dealing with boilerplate changes like this one. Even if you do give me that level of access I reckon your review might be necessary for the upcoming type changes since there's a chance I won't cover edge cases you know about.

koresar commented 1 year ago

Makes sense. Then I'll just wait for the next PRs.

I'm super pumped about this whole TS thing. Would be very useful!

koresar commented 1 year ago

@sammys not sure, but looks like I've given you Admin access to this repo. Enjoy.

sammys commented 1 year ago

Moved the issue post from stampit to #84