search

stampit-org / stampit

OOP is better with stamps: Composable object factories.
https://stampit.js.org
MIT License
3.02k stars 103 forks source link

TypeError·Object expected in combineProperties in IE11 #316

Closed kellypacker closed 7 years ago

kellypacker commented 7 years ago

Getting this error only in IE11 (not Chrome or Firefox). Live example. I tried to track down the cause, but got a bit lost. I can try to create a standalone example of this, but wanted to also check and see if this rings any bells with someone who knows the library. Thanks for any help.

koresar commented 7 years ago

@kellypacker could you please provide: 1) version of the stampit 2) full stack trace.

danielkcz commented 7 years ago

@kellypacker Please see the install section in readme, especially that warning there :) This is actually what's your problem there.

@koresar It's coming from here: https://github.com/stampit-org/stampit/blob/master/src/utils.js#L41 because Object.assign is not defined :) I think we should add a warning to stamp/core about this just to avoid these weird errors.

kellypacker commented 7 years ago

@FredyC ah, I missed that. That was the issue. Thank you for the response!

koresar commented 7 years ago

@kellypacker As of v3.2.0 stampit do not need polyfils. Works in IE11 out of the box. :)