search

stampit-org / stampit

OOP is better with stamps: Composable object factories.
https://stampit.js.org
MIT License
3.02k stars 103 forks source link

IE11 and node.js 0.10 support by adding 100 more bytes to the bundle #321

Closed koresar closed 7 years ago

koresar commented 7 years ago

This removes the burden many people have. They don't need to polyfil anything now. With this PR Stampit core feature - dependencelessness (What a word!) is preserved. The resulting minified bundle increases by 100 bytes, the .min.gz bundle increases by 40 bytes. :)

ericelliott commented 7 years ago

IMO, this is a bad idea.

danielkcz commented 7 years ago

I think we can merge this for now and later we can try the approach through compat if needed. Question is, should we do something similar in @stamp/it also?

ericelliott commented 7 years ago

Reminder: we're adding ~10 Megabytes of wasted code to the world with this PR, and the correct solution for Stampit users is to use a polyfill CDN.

It is not a library's responsibility to supply polyfills for application authors.

Objection filed. My work here is done. I wash my hands of this.

koresar commented 7 years ago

@FredyC good question... Let me think.