search

stampit-org / stampit

OOP is better with stamps: Composable object factories.
https://stampit.js.org
MIT License
3.02k stars 102 forks source link

feat: add version number to Stampit API #333

Closed dwiyatci closed 6 years ago

dwiyatci commented 6 years ago

This should close #332.

danielkcz commented 6 years ago

I think this needs some sort of automation as a part of release process or at least document it somewhere. But that's just my point of view. It's up the @koresar who is making releases if he will be able to remember updating that number there manually.

koresar commented 6 years ago

Yeah. I don't trust myself much. Automation would help significantly.

The 'npm run build' would need to have one more command to replace the "STAMPIT_VERSION" string in the minified bundle with whatever is in the package.json.version. And the source code would need to have ".version = 'STAMPIT_VERSION'".

If sounds too complicated for you Glenn, I can do it myself today evening. (currently morning in Australia)

koresar commented 6 years ago

Oh, hold on... That wouldn't work. Need to think a little.

dwiyatci commented 6 years ago

Right. Automation FTW!

And yes, please. Feel free to decline this PR and take it over, Vasyl. I don't think I have too much spare time these days 🙃

koresar commented 6 years ago

PR #334 created.

Thanks @dwiyatci Btw, you created PR number 333. Congrats on that smoosh number!