search

stampit-org / stampit

OOP is better with stamps: Composable object factories.
https://stampit.js.org
MIT License
3.02k stars 102 forks source link

fix issue #344, but can not pass test #345

Closed lornally closed 5 years ago

lornally commented 5 years ago

maybe deep, static, property and method clone need fix.

lornally commented 5 years ago

i have push the pr, and, because the eslint error, so i do a prettier format, sorry.

koresar commented 5 years ago

No worries mate. All good. I'll take a look later.

lornally commented 5 years ago

sorry there is a format error, too.

lornally commented 5 years ago

sorry, mate, there is error still, and i can not deal it. help :)

koresar commented 5 years ago

I will take a look today or tomorrow. Very busy at work currently. Sorry about that

lornally commented 5 years ago

you are welcome. and ask a digression from this issue, how can you react so in time? you can receive some github message? or maybe we can contact each other with some IM tools.

koresar commented 5 years ago

@lornally I do receive emails for each of the issue, PR or comment. :) You can reach me on twitter https://twitter.com/kore_sar

lornally commented 5 years ago

thank you, i will set github so i can receive the mail too. btw, the pr can pass npm test, but can not pass CI. my email: machangkun@me.com, we can connect by email too.

lornally commented 5 years ago

hi, mate, can we continue?

koresar commented 5 years ago

Yes we can. But after this one merged. https://github.com/stampit-org/stamp-specification/pull/128

The specification is a crucial part of the project. Every module which implements the stamp specification must fully comply.

Thus I believe it would be a good idea to wait for the next version of the specification.

Sorry I didn't mention it earlier

On Thu., 27 Jun. 2019, 18:11 茂弘, notifications@github.com wrote:

hi, mate, can we continue?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stampit-org/stampit/pull/345?email_source=notifications&email_token=AAMMELYE2JTXURD773ANGB3P4RYZTA5CNFSM4HW2G3WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYWKEOQ#issuecomment-506241594, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMMEL3RUBG3MKVL245R3ELP4RYZTANCNFSM4HW2G3WA .

lornally commented 5 years ago

ok, no problem, you are welcome, let us do it, we can build the specification now:)

koresar commented 5 years ago

Implemented with #346