Resolve some unused variable warnings

[WardBrian]

Submisison Checklist

• [x] Run tests: ./runCmdStanTests.py src/test
• [x] Declare copyright holder and open-source license: see below

Summary:

Resolves some unused variable warnings shown in make build

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
• Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[WardBrian]

@serban-nicusor-toptal This is getting an error from the quality gate I don't understand, could you take a look?

[serban-nicusor-toptal]

Hmh, weird, it's complaining about some regex I think:

java.util.regex.PatternSyntaxException: Dangling meta character '*' near index 0

Checking ...

[serban-nicusor-toptal]

My first guess is that something changed in the output and the parser of the warnings plugin does not like it. Looks like this line is failing the pipeline excludeMessage("*'sprintf' is deprecated*") https://github.com/stan-dev/cmdstan/blob/develop/Jenkinsfile#L234C37-L234C76 I hope this is not because of a plugin update as that will affect us in all pipelines. ( Looks like it's not )

[serban-nicusor-toptal]

I think if we change that to: .*'sprintf' is deprecated.* will make the regex valid. I'm not entirely sure why it failed now tho.

[WardBrian]

Ok, the odd CI failures seem sorted. Mind giving this a review now @mitzimorris?