Closed WardBrian closed 7 months ago
@serban-nicusor-toptal is there an easy way to set -Wp,-D_GLIBCXX_ASSERTIONS
in our CI? Seems like it would catch things like this earlier.
I think the easiest way is to add that at the end of writeFile
here https://github.com/stan-dev/cmdstan/blob/develop/Jenkinsfile#L11
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Resolves #1238. An unchecked indexing operation on an empty string introduced by #1228 causes a crash if compiled with
-Wp,-D_GLIBCXX_ASSERTIONS
, and possibly under other conditionsIntended Effect:
Resolves the crash
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: