Closed WardBrian closed 6 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.19 | 0.18 | 1.05 | 4.83% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.92 | -8.56% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.01 | 1.4% faster |
gp_regr/gp_regr.stan | 0.11 | 0.1 | 1.05 | 4.47% faster |
sir/sir.stan | 78.03 | 74.84 | 1.04 | 4.09% faster |
irt_2pl/irt_2pl.stan | 3.91 | 3.94 | 0.99 | -0.79% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.0 | -0.34% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 0.99 | -0.74% slower |
pkpd/one_comp_mm_elim_abs.stan | 18.02 | 18.34 | 0.98 | -1.79% slower |
garch/garch.stan | 0.47 | 0.46 | 1.01 | 0.74% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.9 | 2.81 | 1.03 | 3.34% faster |
arK/arK.stan | 2.05 | 1.69 | 1.21 | 17.66% faster |
gp_pois_regr/gp_pois_regr.stan | 2.52 | 2.6 | 0.97 | -2.81% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.45 | 8.93 | 1.06 | 5.56% faster |
performance.compilation | 171.42 | 172.77 | 0.99 | -0.79% slower |
Mean result: 1.0213192855862943
Jenkins Console Log Blue Ocean Commit hash: 6af63a9f1fbd2016d2c739705e5aac183ffb8fcc
I think differences at the levels reported there are pretty much up to noise/what else would be running on the machine
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
This helps break up the large
command_helper.hpp
file by moving logic involving the filesystem to its own helper.It also wraps up some common functionality around setting up an
ofstream
for writing into a new function, and setsbadbit
so that an exception gets thrown on by any "Read/writing error on i/o operation". This closes https://github.com/stan-dev/stan/issues/2536Intended Effect:
Clean up command_helper, add safeguards against things like running out of disk space.
How to Verify:
This is harder - I don't know how to write a test which mocks the disk running out of space.
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: