Closed mitzimorris closed 6 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.26 | 0.19 | 1.36 | 26.2% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.95 | -5.76% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 0.99 | -1.39% slower |
gp_regr/gp_regr.stan | 0.16 | 0.1 | 1.57 | 36.36% faster |
sir/sir.stan | 75.97 | 73.69 | 1.03 | 3.0% faster |
irt_2pl/irt_2pl.stan | 4.45 | 3.66 | 1.22 | 17.87% faster |
eight_schools/eight_schools.stan | 0.08 | 0.05 | 1.53 | 34.61% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.24 | 0.24 | 1.01 | 1.2% faster |
pkpd/one_comp_mm_elim_abs.stan | 20.12 | 17.2 | 1.17 | 14.5% faster |
garch/garch.stan | 0.5 | 0.43 | 1.15 | 13.26% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 3.43 | 2.65 | 1.29 | 22.51% faster |
arK/arK.stan | 2.16 | 1.56 | 1.38 | 27.75% faster |
gp_pois_regr/gp_pois_regr.stan | 3.18 | 2.42 | 1.31 | 23.88% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.52 | 8.78 | 1.08 | 7.74% faster |
performance.compilation | 170.94 | 172.05 | 0.99 | -0.65% slower |
Mean result: 1.202417887992028
Jenkins Console Log Blue Ocean Commit hash: d1c6b7c740d486cba81292100a0c469eb4b6b4cb
note that the makefile comments for developers provide info on how to compile print
, should one so desire.
What's the reasoning for doing this now if the previous comment said it would be available until 3.0?
watching cmdstan build on a slow machine is painful and I happened to be watching the console while print
was being built. overall, it doesn't matter one way or another.
I think we should either keep building it or go further and remove the code entirely. Keeping the code around but not building it by default seems like it would still break anyone's workflow who does still rely on it, but also not actually decrease the code surface area of the repo
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
remove deprecated utility from CmdStan makefile target
build
Intended Effect:
speed up the build process (a little)
How to Verify:
run:
verify that no program
print
in subdirbin
.Side Effects:
Documentation:
Makefile comments.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: