stan-dev / cmdstan

CmdStan, the command line interface to Stan
https://mc-stan.org/users/interfaces/cmdstan
BSD 3-Clause "New" or "Revised" License
210 stars 93 forks source link

cmdstan 2.34.1 source does not have stan_math? #1252

Closed segasai closed 6 months ago

segasai commented 6 months ago

Summary:

The released 2.34.1 .tar.gz of cmdstan doesn't seem to include stan_math.

Description:

Previously (at least 2.32.2 version I have around) included stan_math.

Reproducible Steps:

Download cmdstan-2.34.1.tar.gz unpack and run make build which gives

ERROR: Missing Stan submodules.
We tried to find the Stan Math submodule at:

Current Version:

v2.34.1

I understand that the git repo checkout needs the git submodule steps, but I was assuming that the provided .tar.gz should work without that (and that was the case before).

Thanks

mitzimorris commented 6 months ago

did you run make build from the cmdstan-2.34.1 directory? I just downloaded the 2.34.1 release, unzipped it, and tar -t shows all stan_math files are there - subdir stan/lib/stan_math

cmdstan-2.34.1/stan/lib/stan_math/stan/
cmdstan-2.34.1/stan/lib/stan_math/stan/math/
cmdstan-2.34.1/stan/lib/stan_math/stan/math/version.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/core.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/functor.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/fun/
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/fun/acos.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/fun/trace.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/fun/is_nan.hpp
cmdstan-2.34.1/stan/lib/stan_math/stan/math/rev/fun/to_var.hpp

builds on my machine (mac OSX 12.7.2)

segasai commented 6 months ago

My apologies. I don't quite know how it happened. I can see the file is indeed smaller than needed

$ ls -lth cmdstan-2.34.1.tar.gz -rw-rw-r-- 1 .. 1.5M Feb 26 16:46 cmdstan-2.34.1.tar.gz

and when redownloading stan_math is there.

Sorry for the noise