Closed SteveBronder closed 4 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.25 | 0.19 | 1.36 | 26.38% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.99 | -1.5% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.02 | 1.79% faster |
gp_regr/gp_regr.stan | 0.1 | 0.1 | 0.99 | -0.84% slower |
sir/sir.stan | 74.41 | 74.39 | 1.0 | 0.03% faster |
irt_2pl/irt_2pl.stan | 3.67 | 3.72 | 0.99 | -1.28% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.03 | 2.97% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.24 | 0.24 | 0.99 | -1.05% slower |
pkpd/one_comp_mm_elim_abs.stan | 17.31 | 17.45 | 0.99 | -0.78% slower |
garch/garch.stan | 0.43 | 0.44 | 0.98 | -1.84% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.75 | 2.72 | 1.01 | 1.27% faster |
arK/arK.stan | 1.57 | 1.6 | 0.98 | -1.79% slower |
gp_pois_regr/gp_pois_regr.stan | 2.42 | 2.47 | 0.98 | -1.73% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 8.8 | 8.88 | 0.99 | -0.87% slower |
performance.compilation | 167.17 | 166.95 | 1.0 | 0.13% faster |
Mean result: 1.020425932711259
Jenkins Console Log Blue Ocean Commit hash: f70fb84db501edcbf822691c02664c43b76287b2
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.18 | 0.19 | 0.96 | -4.0% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.94 | -5.95% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.06 | 5.64% faster |
gp_regr/gp_regr.stan | 0.1 | 0.1 | 1.02 | 1.86% faster |
sir/sir.stan | 73.53 | 74.3 | 0.99 | -1.04% slower |
irt_2pl/irt_2pl.stan | 3.65 | 3.65 | 1.0 | -0.12% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.02 | 1.8% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.24 | 0.24 | 1.0 | 0.06% faster |
pkpd/one_comp_mm_elim_abs.stan | 17.65 | 16.92 | 1.04 | 4.16% faster |
garch/garch.stan | 0.43 | 0.43 | 1.0 | 0.22% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.63 | 2.71 | 0.97 | -2.82% slower |
arK/arK.stan | 1.55 | 1.56 | 0.99 | -0.74% slower |
gp_pois_regr/gp_pois_regr.stan | 2.42 | 2.43 | 1.0 | -0.32% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 8.74 | 8.73 | 1.0 | 0.08% faster |
performance.compilation | 165.73 | 171.31 | 0.97 | -3.37% slower |
Mean result: 0.9978249235584149
Jenkins Console Log Blue Ocean Commit hash: ea7043685c46633665df0e8aa395b1788e27f920
@SteveBronder your last commit here deleted a variable that seems to still be used elsewhere. It would be nice to get this into 2.35 if you can take a quick look
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.22 | 0.22 | 1.02 | 2.17% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.95 | -4.72% slower |
gp_regr/gen_gp_data.stan | 0.03 | 0.02 | 1.18 | 14.93% faster |
gp_regr/gp_regr.stan | 0.12 | 0.11 | 1.03 | 3.28% faster |
sir/sir.stan | 83.61 | 82.65 | 1.01 | 1.15% faster |
irt_2pl/irt_2pl.stan | 4.08 | 4.15 | 0.98 | -1.59% slower |
eight_schools/eight_schools.stan | 0.05 | 0.06 | 0.84 | -19.72% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.27 | 0.28 | 0.98 | -2.24% slower |
pkpd/one_comp_mm_elim_abs.stan | 19.28 | 19.33 | 1.0 | -0.28% slower |
garch/garch.stan | 0.47 | 0.49 | 0.95 | -5.61% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.95 | 2.99 | 0.99 | -1.19% slower |
arK/arK.stan | 1.73 | 1.76 | 0.98 | -2.24% slower |
gp_pois_regr/gp_pois_regr.stan | 2.58 | 2.69 | 0.96 | -3.97% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.74 | 9.89 | 0.98 | -1.53% slower |
performance.compilation | 207.58 | 212.41 | 0.98 | -2.32% slower |
Mean result: 0.9886849526204249
Jenkins Console Log Blue Ocean Commit hash: d8ac1c67d08c8b579e1b20ed5747abacce87c6fc
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.21 | 0.2 | 1.05 | 4.7% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.97 | -3.55% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 0.99 | -1.11% slower |
gp_regr/gp_regr.stan | 0.11 | 0.11 | 1.0 | -0.07% slower |
sir/sir.stan | 80.01 | 79.1 | 1.01 | 1.13% faster |
irt_2pl/irt_2pl.stan | 3.97 | 3.99 | 0.99 | -0.51% slower |
eight_schools/eight_schools.stan | 0.05 | 0.06 | 0.96 | -4.03% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 1.02 | 1.73% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.51 | 18.57 | 1.0 | -0.37% slower |
garch/garch.stan | 0.47 | 0.47 | 1.01 | 1.37% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.84 | 2.9 | 0.98 | -2.1% slower |
arK/arK.stan | 1.74 | 1.69 | 1.03 | 2.81% faster |
gp_pois_regr/gp_pois_regr.stan | 2.61 | 2.56 | 1.02 | 1.96% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.57 | 9.59 | 1.0 | -0.11% slower |
performance.compilation | 192.32 | 177.49 | 1.08 | 7.71% faster |
Mean result: 1.007307180824768
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.23 | 0.2 | 1.15 | 13.18% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.94 | -6.39% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.04 | 4.21% faster |
gp_regr/gp_regr.stan | 0.11 | 0.11 | 1.0 | -0.05% slower |
sir/sir.stan | 80.14 | 77.74 | 1.03 | 3.0% faster |
irt_2pl/irt_2pl.stan | 3.96 | 4.02 | 0.98 | -1.59% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 0.99 | -0.71% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 0.98 | -1.86% slower |
pkpd/one_comp_mm_elim_abs.stan | 18.48 | 18.27 | 1.01 | 1.13% faster |
garch/garch.stan | 0.46 | 0.5 | 0.92 | -8.11% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 3.06 | 2.82 | 1.09 | 7.84% faster |
arK/arK.stan | 1.69 | 1.67 | 1.01 | 1.3% faster |
gp_pois_regr/gp_pois_regr.stan | 2.63 | 2.56 | 1.02 | 2.43% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.55 | 9.32 | 1.02 | 2.4% faster |
performance.compilation | 185.69 | 190.69 | 0.97 | -2.7% slower |
Mean result: 1.0122065511050453
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.21 | 0.19 | 1.08 | 7.43% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.03 | 2.63% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.01 | 0.96% faster |
gp_regr/gp_regr.stan | 0.12 | 0.11 | 1.08 | 7.25% faster |
sir/sir.stan | 78.89 | 77.79 | 1.01 | 1.4% faster |
irt_2pl/irt_2pl.stan | 3.87 | 3.86 | 1.0 | 0.46% faster |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 0.99 | -1.42% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 1.01 | 1.44% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.23 | 17.66 | 1.03 | 3.14% faster |
garch/garch.stan | 0.46 | 0.45 | 1.03 | 2.59% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.95 | 2.79 | 1.06 | 5.25% faster |
arK/arK.stan | 1.67 | 1.66 | 1.0 | 0.07% faster |
gp_pois_regr/gp_pois_regr.stan | 2.57 | 2.46 | 1.05 | 4.57% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.34 | 9.12 | 1.02 | 2.33% faster |
performance.compilation | 179.58 | 177.79 | 1.01 | 1.0% faster |
Mean result: 1.02741166325575
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.25 | 0.24 | 1.03 | 3.01% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.89 | -11.88% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 0.97 | -3.52% slower |
gp_regr/gp_regr.stan | 0.1 | 0.1 | 0.99 | -1.23% slower |
sir/sir.stan | 74.3 | 73.88 | 1.01 | 0.57% faster |
irt_2pl/irt_2pl.stan | 3.63 | 3.69 | 0.98 | -1.6% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.05 | 4.73% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.24 | 0.24 | 1.01 | 1.26% faster |
pkpd/one_comp_mm_elim_abs.stan | 17.26 | 17.38 | 0.99 | -0.65% slower |
garch/garch.stan | 0.45 | 0.43 | 1.05 | 4.62% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.68 | 2.71 | 0.99 | -1.38% slower |
arK/arK.stan | 1.6 | 1.55 | 1.03 | 3.35% faster |
gp_pois_regr/gp_pois_regr.stan | 2.57 | 2.43 | 1.06 | 5.24% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.13 | 8.71 | 1.05 | 4.65% faster |
performance.compilation | 177.39 | 171.91 | 1.03 | 3.09% faster |
Mean result: 1.008671841131272
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.21 | 0.24 | 0.88 | -13.62% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.09 | 7.92% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.06 | 5.83% faster |
gp_regr/gp_regr.stan | 0.11 | 0.1 | 1.07 | 6.97% faster |
sir/sir.stan | 79.72 | 74.38 | 1.07 | 6.7% faster |
irt_2pl/irt_2pl.stan | 4.18 | 3.62 | 1.16 | 13.47% faster |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.04 | 3.82% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.26 | 0.24 | 1.08 | 7.21% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.61 | 17.12 | 1.09 | 8.0% faster |
garch/garch.stan | 0.45 | 0.43 | 1.07 | 6.24% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.85 | 2.69 | 1.06 | 5.42% faster |
arK/arK.stan | 1.66 | 1.57 | 1.06 | 5.51% faster |
gp_pois_regr/gp_pois_regr.stan | 2.55 | 2.39 | 1.07 | 6.43% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.29 | 8.7 | 1.07 | 6.31% faster |
performance.compilation | 182.55 | 170.06 | 1.07 | 6.84% faster |
Mean result: 1.0617705248428513
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.22 | 0.2 | 1.11 | 9.93% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.88 | -13.3% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.0 | -0.12% slower |
gp_regr/gp_regr.stan | 0.11 | 0.12 | 0.89 | -12.1% slower |
sir/sir.stan | 78.68 | 78.71 | 1.0 | -0.04% slower |
irt_2pl/irt_2pl.stan | 3.86 | 3.87 | 1.0 | -0.25% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.01 | 1.21% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.24 | 1.04 | 4.05% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.17 | 18.0 | 1.01 | 0.95% faster |
garch/garch.stan | 0.46 | 0.46 | 0.99 | -0.71% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.85 | 2.72 | 1.05 | 4.63% faster |
arK/arK.stan | 1.66 | 1.58 | 1.05 | 5.14% faster |
gp_pois_regr/gp_pois_regr.stan | 2.52 | 2.49 | 1.01 | 1.25% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.41 | 8.95 | 1.05 | 4.84% faster |
performance.compilation | 182.99 | 179.81 | 1.02 | 1.74% faster |
Mean result: 1.0081325522748001
Jenkins Console Log Blue Ocean Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774
@WardBrian I think I fix up the issues
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Note the line change # here is just from adding the test files. Theres about 100 code line changes in total
This swaps out the old
generated_quantities
function call for the new parallel version.This is pretty straightforward besides the changes to
get_num_chains
. For generated quantities, we don't have the user pass the number of chains, so we need to do some deduction to figure out how many chains the program will be running. We use similar logic to how we figure out the number of inits. If the user supplies just amy_file_name.csv
then we assume it's just 1 chain. But if a user suppliesmy_file_name_{id}.csv
we search formy_file_name_{{id} + 1, {id} _ 2,..., {id} + N}
sequentially until we cannot find anymore files. The total number of files is the total number of chains.Intended Effect:
Allow users to call generated quantities in parallel.
How to Verify:
I only wrote one test in
generated_quantities_test.cpp
that checks that the program does not error out. Is that sufficient?Side Effects:
Documentation:
Docs added for new file
file::exists()
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simon's Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: