Closed WardBrian closed 5 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.27 | 0.32 | 0.84 | -19.2% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.05 | 4.6% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.05 | 4.99% faster |
gp_regr/gp_regr.stan | 0.11 | 0.11 | 1.01 | 0.56% faster |
sir/sir.stan | 77.35 | 73.77 | 1.05 | 4.62% faster |
irt_2pl/irt_2pl.stan | 3.95 | 3.6 | 1.1 | 8.7% faster |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.08 | 7.54% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.26 | 0.23 | 1.11 | 9.76% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.3 | 17.11 | 1.07 | 6.48% faster |
garch/garch.stan | 0.46 | 0.42 | 1.09 | 8.0% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.78 | 2.68 | 1.04 | 3.65% faster |
arK/arK.stan | 1.55 | 1.54 | 1.01 | 0.7% faster |
gp_pois_regr/gp_pois_regr.stan | 2.42 | 2.45 | 0.99 | -1.27% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 8.79 | 8.71 | 1.01 | 0.93% faster |
performance.compilation | 181.21 | 173.44 | 1.04 | 4.29% faster |
Mean result: 1.0347787307693712
Jenkins Console Log Blue Ocean Commit hash: 55780cd9d44e830a187acabc2323cbeab19f7b16
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.21 | 0.18 | 1.13 | 11.76% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.08 | 7.13% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.01 | 1.33% faster |
gp_regr/gp_regr.stan | 0.11 | 0.1 | 1.07 | 6.56% faster |
sir/sir.stan | 77.14 | 74.94 | 1.03 | 2.85% faster |
irt_2pl/irt_2pl.stan | 3.86 | 3.91 | 0.99 | -1.51% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.02 | 2.12% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 0.99 | -1.39% slower |
pkpd/one_comp_mm_elim_abs.stan | 17.91 | 18.48 | 0.97 | -3.19% slower |
garch/garch.stan | 0.47 | 0.47 | 0.98 | -1.61% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.78 | 2.87 | 0.97 | -3.36% slower |
arK/arK.stan | 1.63 | 1.65 | 0.99 | -1.48% slower |
gp_pois_regr/gp_pois_regr.stan | 2.53 | 2.54 | 1.0 | -0.5% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.14 | 9.28 | 0.99 | -1.47% slower |
performance.compilation | 183.73 | 178.23 | 1.03 | 2.99% faster |
Mean result: 1.0155744112826153
Jenkins Console Log Blue Ocean Commit hash: 55780cd9d44e830a187acabc2323cbeab19f7b16
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
A (undocumented? whoops!) change in 2.34 was allowing
true
andfalse
as boolean argument values in addition to1
and0
. This change makes it so the command line and CSV files print them as suchIntended Effect:
Give more human (and frankly, machine) readable output
How to Verify:
See test changes.
Side Effects:
I am unsure, it's possible this would need changes in cmdstanpy/cmdstanr downstream?
Documentation:
TBD
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: