Closed WardBrian closed 3 months ago
Good morning @WardBrian, I don't see anything pending in the discourse thread nor here. I will start shortly with the RC.
RC is now out! Version increment PRs merged, release notes to be added later on.
CmdStanR tests running at https://github.com/stan-dev/cmdstanr/actions/runs/9062601485
Thank you! I will get working on release notes and a discourse post
Hi @serban-nicusor-toptal - unfortunately I immediately found an issue - see #1270
Additionally, the stanc
in the tarballs of rc1 reports the wrong version (it seems like stanc3 is missing a rc tag/build?)
Ah, I thought for stanc3 we'll just use nightly
.
I will tag it 2.35.0-rc1
in just a moment so it start building then I will redo the tarballs.
I will merge #1270 as soon as its tests pass and then you can do another set of tars
Been a while since we had an rc2, I think.
@serban-nicusor-toptal Merged, can re-tarball when you get a chance
Preliminary (lightly edited) release notes here: https://gist.github.com/WardBrian/0791d82cfde4044a4b9c78aaf91f7c84
Properly tagged stanc3 binaries currently building here https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/v2.35.0-rc1/1/pipeline I'll fix RC1 tarballs when that will finish building. I'm waiting before I do RC2 for cmdstan
Ok, https://github.com/stan-dev/cmdstan/pull/1271 should be in rc2, I think.
@serban-nicusor-toptal I think we can do rc2 now
@WardBrian that's great! I can get to it in a few minutes. Only cmdstan
right ?
Yep! just the couple commits here and the re-built stanc3
rc2 for cmdstan is up! https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0-rc2 colab is building, takes 10~mins
CmdStanpy tests are normal. @andrjohns @jgabry can you comment on the cmdstanr tests? https://github.com/stan-dev/cmdstanr/actions/runs/9069238610/job/24918334234
@serban-nicusor-toptal just a heads up, we will want a resolution to https://github.com/stan-dev/stan/issues/3285 before any release. Depending on what we decide we may even want another round of RCs, so probably ~May 28 for the actual release at this point
PRs we have merged/are aiming to merge between the first round of RCs and another round/eventual release:
@serban-nicusor-toptal I think we are ready for another round of RCs tomorrow. Would you mind running them in the morning?
Unfortunately we need new RCs for everything:
@WardBrian That's great! I'll do it tomorrow before US morning so it's ready when you log in.
Thanks @serban-nicusor-toptal!
I'm going to discuss when we'd like to do the official release with some other team members a bit later and get back to you.
@serban-nicusor-toptal We decided to wait until the next non-US-holiday Monday, so we'd like to release on Monday, June 3rd
Hi @serban-nicusor-toptal - it seems like cmdstan-2.35.0-rc3.tar.gz is missing https://github.com/stan-dev/math/pull/3077 in the math submodule included in the tarball.
Would you mind producing a new one?
Not at all! They're up now @WardBrian
Releases are out now!
https://github.com/stan-dev/math/releases/tag/v4.9.0 https://github.com/stan-dev/stan/releases/tag/v2.35.0 https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0 https://github.com/stan-dev/stanc3/releases/tag/v2.35.0
Docs building at: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FBuildDocs/detail/BuildDocs/52/pipeline
@serban-nicusor-toptal great!
I think everything is looking good on the git side of things. We still need to make the develop
-> master
merges at some point
Feature freeze (May 13th, 2024):
Release (June 3rd, 2024):