Release CmdStan 2.35 - Githubissues

WardBrian commented 4 months ago

Feature freeze (May 13th, 2024):

[x] Ensure all expiring language deprecations have been removed or given new removal dates.
[x] Create and merge version updating pull requests in Math/Stan/Cmdstan. These should be the last PRs accepted before the freeze.
[x] Create Math/Stan RC releases.
[x] Create Stanc3 RC binary.
[x] Create a release candidate tarball for x86. Make sure RC tarballs include stanc3 binaries.
[x] Check external links in docs (i.e. TBB docs link) - use https://github.com/tcort/markdown-link-check
[x] Create a release candidate feature/bugfix list (major features/bugfixes that need testing, link to new docs in Github)
[x] Run CmdStanR tests with the RC tarball.
[x] Run CmdStanPy tests with the RC tarball.
[x] Make a Discourse RC post.
[ ] Post a tweet with a link to the Discourse RC post.

Release (June 3rd, 2024):

[x] Create the Math Release notes.
[x] Create the Stan Release notes.
[x] Create the Cmdstan Release notes.
[x] Create the Stanc3 Release notes, include new deprecations and removals.
[x] Rebuild and publish docs for the new version.
[x] Check that docs for the previous release links correctly to the newest docs.
[x] Create the Math release.
[x] Create the Stan release.
[x] Create the Stanc3 release.
[x] Create x86 CmdStan tarballs (check version, check that the extracted folder is in the cmdstan-version format).
[x] Create non-x86 CmdStan tarballs.
[ ] Run CmdStanR tests with the release tarball.
[x] Make a Stan blog release announcement post (thank the sponsors and all contributors, mention new devs).
[x] Link to the blog post in a Discourse thread.
[ ] Make a Twitter announcement.

serban-nicusor-toptal commented 3 months ago

Good morning @WardBrian, I don't see anything pending in the discourse thread nor here. I will start shortly with the RC.

serban-nicusor-toptal commented 3 months ago

RC is now out! Version increment PRs merged, release notes to be added later on.

CmdStanR tests running at https://github.com/stan-dev/cmdstanr/actions/runs/9062601485

WardBrian commented 3 months ago

Thank you! I will get working on release notes and a discourse post

WardBrian commented 3 months ago

Hi @serban-nicusor-toptal - unfortunately I immediately found an issue - see #1270

Additionally, the stanc in the tarballs of rc1 reports the wrong version (it seems like stanc3 is missing a rc tag/build?)

serban-nicusor-toptal commented 3 months ago

Ah, I thought for stanc3 we'll just use nightly. I will tag it 2.35.0-rc1 in just a moment so it start building then I will redo the tarballs.

WardBrian commented 3 months ago

I will merge #1270 as soon as its tests pass and then you can do another set of tars

Been a while since we had an rc2, I think.

WardBrian commented 3 months ago

@serban-nicusor-toptal Merged, can re-tarball when you get a chance

WardBrian commented 3 months ago

Preliminary (lightly edited) release notes here: https://gist.github.com/WardBrian/0791d82cfde4044a4b9c78aaf91f7c84

serban-nicusor-toptal commented 3 months ago

Properly tagged stanc3 binaries currently building here https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/v2.35.0-rc1/1/pipeline I'll fix RC1 tarballs when that will finish building. I'm waiting before I do RC2 for cmdstan

WardBrian commented 3 months ago

Ok, https://github.com/stan-dev/cmdstan/pull/1271 should be in rc2, I think.

WardBrian commented 3 months ago

@serban-nicusor-toptal I think we can do rc2 now

serban-nicusor-toptal commented 3 months ago

@WardBrian that's great! I can get to it in a few minutes. Only cmdstan right ?

WardBrian commented 3 months ago

Yep! just the couple commits here and the re-built stanc3

serban-nicusor-toptal commented 3 months ago

rc2 for cmdstan is up! https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0-rc2 colab is building, takes 10~mins

WardBrian commented 3 months ago

CmdStanpy tests are normal. @andrjohns @jgabry can you comment on the cmdstanr tests? https://github.com/stan-dev/cmdstanr/actions/runs/9069238610/job/24918334234

WardBrian commented 3 months ago

@serban-nicusor-toptal just a heads up, we will want a resolution to https://github.com/stan-dev/stan/issues/3285 before any release. Depending on what we decide we may even want another round of RCs, so probably ~May 28 for the actual release at this point

WardBrian commented 3 months ago

PRs we have merged/are aiming to merge between the first round of RCs and another round/eventual release:

WardBrian commented 3 months ago

@serban-nicusor-toptal I think we are ready for another round of RCs tomorrow. Would you mind running them in the morning?

Unfortunately we need new RCs for everything:

math: v4.9.0-rc2
stan: v2.35.0-rc2
stanc3: v2.35.0-rc2
cmdstan: v2.35.0-rc3

serban-nicusor-toptal commented 3 months ago

@WardBrian That's great! I'll do it tomorrow before US morning so it's ready when you log in.

serban-nicusor-toptal commented 3 months ago

Good morning @WardBrian, everything is ready:

WardBrian commented 3 months ago

Thanks @serban-nicusor-toptal!

I'm going to discuss when we'd like to do the official release with some other team members a bit later and get back to you.

WardBrian commented 3 months ago

@serban-nicusor-toptal We decided to wait until the next non-US-holiday Monday, so we'd like to release on Monday, June 3rd

WardBrian commented 3 months ago

Hi @serban-nicusor-toptal - it seems like cmdstan-2.35.0-rc3.tar.gz is missing https://github.com/stan-dev/math/pull/3077 in the math submodule included in the tarball.

Would you mind producing a new one?

serban-nicusor-toptal commented 3 months ago

Not at all! They're up now @WardBrian

serban-nicusor-toptal commented 3 months ago

Releases are out now!

https://github.com/stan-dev/math/releases/tag/v4.9.0 https://github.com/stan-dev/stan/releases/tag/v2.35.0 https://github.com/stan-dev/cmdstan/releases/tag/v2.35.0 https://github.com/stan-dev/stanc3/releases/tag/v2.35.0

Docs building at: https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FBuildDocs/detail/BuildDocs/52/pipeline

WardBrian commented 3 months ago

@serban-nicusor-toptal great!

I think everything is looking good on the git side of things. We still need to make the develop -> master merges at some point

stan-dev / cmdstan

Release CmdStan 2.35 #1266