Closed WardBrian closed 3 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.2 | 0.2 | 0.97 | -2.93% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.97 | -2.73% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 0.98 | -1.93% slower |
gp_regr/gp_regr.stan | 0.11 | 0.11 | 0.98 | -2.06% slower |
sir/sir.stan | 79.77 | 87.06 | 0.92 | -9.14% slower |
irt_2pl/irt_2pl.stan | 4.0 | 4.93 | 0.81 | -23.13% slower |
eight_schools/eight_schools.stan | 0.06 | 0.06 | 0.98 | -2.47% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.28 | 0.92 | -8.79% slower |
pkpd/one_comp_mm_elim_abs.stan | 18.53 | 18.56 | 1.0 | -0.13% slower |
garch/garch.stan | 0.48 | 0.47 | 1.04 | 3.52% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.92 | 3.13 | 0.93 | -7.32% slower |
arK/arK.stan | 1.68 | 1.99 | 0.85 | -18.04% slower |
gp_pois_regr/gp_pois_regr.stan | 2.61 | 2.6 | 1.01 | 0.57% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.53 | 9.63 | 0.99 | -1.08% slower |
performance.compilation | 198.49 | 187.35 | 1.06 | 5.61% faster |
Mean result: 0.9598692294116096
Jenkins Console Log Blue Ocean Commit hash: 8229477b6234d7c8fc557a960b090f5699c54683
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.24 | 0.21 | 1.16 | 13.5% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.17 | 14.37% faster |
gp_regr/gen_gp_data.stan | 0.03 | 0.02 | 1.08 | 7.57% faster |
gp_regr/gp_regr.stan | 0.12 | 0.11 | 1.07 | 6.36% faster |
sir/sir.stan | 98.54 | 82.72 | 1.19 | 16.05% faster |
irt_2pl/irt_2pl.stan | 5.61 | 4.14 | 1.36 | 26.24% faster |
eight_schools/eight_schools.stan | 0.06 | 0.06 | 1.07 | 6.44% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.28 | 0.26 | 1.05 | 5.18% faster |
pkpd/one_comp_mm_elim_abs.stan | 20.23 | 19.07 | 1.06 | 5.76% faster |
garch/garch.stan | 0.53 | 0.46 | 1.14 | 12.02% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 3.24 | 4.28 | 0.76 | -32.16% slower |
arK/arK.stan | 1.86 | 1.68 | 1.11 | 9.54% faster |
gp_pois_regr/gp_pois_regr.stan | 2.94 | 4.49 | 0.66 | -52.67% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 11.23 | 9.61 | 1.17 | 14.4% faster |
performance.compilation | 253.83 | 189.33 | 1.34 | 25.41% faster |
Mean result: 1.0912024788107948
Jenkins Console Log Blue Ocean Commit hash: 8229477b6234d7c8fc557a960b090f5699c54683
Yes, and I guess it slipped under the radar
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
In #1171 we added the version of the C++ compiler to the precompiled header file name. This works for clang, since we have to explicitly pass
-include-pch path/to/header
, but GCC does an implicit lookup. Since the filename didn't match, it failed.This paragraph in the GCC manual saves us, though:
So we just use that folder instead. Clang still won't care, since we're giving it the path explicitly, but gcc compile times are now back to what you'd expect.
Intended Effect:
How to Verify:
Compile with
PRECOMPILED_HEADERS=false
and then with them enabled, compare timings.Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: