Closed mitzimorris closed 1 month ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.33 | 0.32 | 1.03 | 2.85% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.96 | -4.56% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.01 | 0.88% faster |
gp_regr/gp_regr.stan | 0.1 | 0.1 | 1.04 | 3.44% faster |
sir/sir.stan | 70.79 | 72.79 | 0.97 | -2.81% slower |
irt_2pl/irt_2pl.stan | 4.21 | 4.28 | 0.98 | -1.82% slower |
eight_schools/eight_schools.stan | 0.06 | 0.06 | 1.01 | 1.06% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.25 | 1.0 | 0.4% faster |
pkpd/one_comp_mm_elim_abs.stan | 20.21 | 20.1 | 1.01 | 0.54% faster |
garch/garch.stan | 0.44 | 0.44 | 1.01 | 1.03% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.76 | 2.77 | 1.0 | -0.22% slower |
arK/arK.stan | 1.84 | 1.83 | 1.01 | 0.83% faster |
gp_pois_regr/gp_pois_regr.stan | 2.88 | 2.92 | 0.99 | -1.32% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 8.86 | 8.87 | 1.0 | -0.14% slower |
performance.compilation | 191.84 | 184.32 | 1.04 | 3.92% faster |
Mean result: 1.00319682574808
Jenkins Console Log Blue Ocean Commit hash: c83a397be67c59ba135871db25c53717e78d796e
@nhuurre before looking at this I wanted to ask if you thought we had any chance of merging something like #1054 instead and removing this fixed_param behavior, or should we continue to hack around it?
if we could do something like #1054, then we wouldn't need to do https://github.com/stan-dev/stan/pull/3302 either.
I haven't seen him on github or the Stan Forums for a year or two now so I suppose we'd need someone else to review the pull request anyway. If you want me to argue about HMC and zero-dimensional topology with that someone else -- yes, I can do that.
I believe the pull request was already approved, and I just took a look at it again and it seems fine, so perhaps that is the way to go
At this point we should replace this with a newer version of #1054, right?
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Add logic to the
write_config
method to record whenfixed_param
sampler is used.Intended Effect:
Make it easy to identify StanCSV output files produced by sampler algorithm
fixed_param
, both by humans as well as bystan_csv_reader
.How to Verify:
Unit tests.
Side Effects:
N/A
Documentation:
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: