stan-dev / cmdstanr

CmdStanR: the R interface to CmdStan
https://mc-stan.org/cmdstanr/
Other
144 stars 63 forks source link

Write functions to read CmdStan csv output into R #25

Closed jgabry closed 4 years ago

jgabry commented 4 years ago

The csv output is different depending on whether the CmdStan method is sample, optimize or variational. Right now rstan::read_stan_csv() is used for method=sample, but it doesn't work for the csv output for optimization or variational inference. We also don't want to depend on RStan (#2), so we should eventually not rely on it for method=sample either.

jgabry commented 4 years ago

I have some very basic implementations called read_optim_csv and read_vb_csv in R/utils.R.

Just need to replace rstan::read_stan_csv now

rok-cesnovar commented 4 years ago

How does this differ from #2 ? I might just be missing something.

jgabry commented 4 years ago

2 was specific to not relying on rstan functions. read_stan_csv doesn't work for optimization and vb so I opened this separate issue for more generally tracking the progress on reading output from cmdstan.

jgabry commented 4 years ago

We can close this now though since I think we just need to read the csv for sampling now and that is covered by #2