stan-dev / docs

Documentation for the Stan language and CmdStan
https://mc-stan.org/docs/
Other
37 stars 107 forks source link

Issue/761 efficiency tuning #762

Closed mitzimorris closed 3 months ago

mitzimorris commented 4 months ago

Submission Checklist

Summary

see #761

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

mitzimorris commented 4 months ago

multivariate normal prior on alpha_std and beta_std

hi @rtrangucci - please clarify. in section "Standardizing predictors" - should the model code be changed? or just add this clarification?

mitzimorris commented 4 months ago

made changes, ready for review / re-review. @rtrangucci @bob-carpenter

mitzimorris commented 4 months ago

ready for re-review.

rtrangucci commented 4 months ago

multivariate normal prior on alpha_std and beta_std

hi @rtrangucci - please clarify. in section "Standardizing predictors" - should the model code be changed? or just add this clarification?

I would just add this for clarification because it's not intuitive that independent priors on $(\alpha, \beta)$ maps to a multivariate normal prior on $(\alpha^\prime, \beta^\prime)$ (at least not intuitive to me).

mitzimorris commented 4 months ago

thanks @rtrangucci - changes made.

regarding clarification re independent priors mapping to multivariate prior - it seems a little off topic.

OK, didn't understand this comment before - will try to address.

mitzimorris commented 3 months ago

@rtrangucci ready for re-review.

rtrangucci commented 3 months ago

Looks good!

rtrangucci commented 3 months ago

@mitzimorris Do I need to merge, or can you?

mitzimorris commented 3 months ago

thanks @rtrangucci - I can merge