sampling statement -> distribution statament

stan-dev / docs

Documentation for the Stan language and CmdStan

https://mc-stan.org/docs/

Other

37 stars 107 forks source link

sampling statement -> distribution statament #777

Closed avehtari closed 3 months ago

avehtari commented 3 months ago

This is a proposal to fix #769 by switching sampling statement to distribution statement. In the first phase, I only edited the statements.qmd, and if after additional edits, this would be approved, I would then edit the rest of the qmd's.

A rendered html at https://users.aalto.fi/~ave/reference-manual/statements.html

avehtari commented 3 months ago

Thanks, Bob! I made some edits.

bob-carpenter commented 3 months ago

I marked as approved, so feel free to merge. If you do want to fix the remaining grammar issue (that you didn't introduce!), I'm happy to approve again.

avehtari commented 3 months ago

I edited other qmd-files in reference-manual/
I edited qmd-files in stan-users-guide/
I didn't edit yet functions-reference/*.qmd in case there is some automation used to create these
After these changes the Stan compiler errors and pedantic mode warning messages need to be checked, too
Can we use cross-links from Stan users' guide to Reference manual?
I haven't tested rendering all edited qmd's, but I'll do after the content changes have been approved

avehtari commented 3 months ago

I assume the function reference is generated by

docs/gen_index.py

stanc3 mentions "sampling statement" only in pedantic analysis and one docs/note

stanc3/src/analysis_and_optimization/Pedantic_analysis.ml
stanc3/docs/notes/cpp-statement-generation.txt

stan-mode mentions "sampling statement"

stan-mode/flycheck-stan/semantic_actions_def.cpp
stan-mode/flycheck-stan/error_msgs.txt

There were also a few example-models which mention sampling statement

WardBrian commented 3 months ago

@avehtari would you like to merge this before the 2.35 release?

avehtari commented 3 months ago

It seems no-one is objecting, so yes if that is possible. I'll add commit for docs/gen_index.py in a moment

avehtari commented 3 months ago

I have now made all changes for this docs repo, so this ready to be merged. I can next make a PR for stanc pedantic mode

WardBrian commented 3 months ago

You can just review https://github.com/stan-dev/stanc3/pull/1426 instead :)

avehtari commented 3 months ago

Uh, missed your PR, I'll check that