search

stan-dev / example-models

Example models for Stan
http://mc-stan.org/
772 stars 479 forks source link

Updated the stan syntax to use log_mix #164

Closed jarnefeltoliver closed 4 years ago

jarnefeltoliver commented 4 years ago

Now using log_mix which allowed the deletion of transformed parameters block.

jarnefeltoliver commented 4 years ago

Okay, thanks I will keep those in mind!

Oliver

Lähettäjä: Bob Carpenter notifications@github.com Lähetetty: 11. maaliskuuta 2020 18:09:31 Vastaanottaja: stan-dev/example-models Kopio: Järnefelt Oliver; Author Aihe: Re: [stan-dev/example-models] Updated the stan syntax to use log_mix (#164)

@bob-carpenter approved this pull request.

Looks good. Thanks.

I'm going to merge this, but if you want to keep going:

  1. mu sampling should be vectorized
  2. theta sampling should be removed
  3. 1 instead of 1.0
  4. spaces after commas and around operators (other than :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/stan-dev/example-models/pull/164#pullrequestreview-372907642, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOCI7KZAZ2GKUFHQGD5E7U3RG6ZTXANCNFSM4LFXN66A.