Run canonicalizer on all models

stan-dev / example-models

Example models for Stan

http://mc-stan.org/

766 stars 478 forks source link

Run canonicalizer on all models #210

Closed WardBrian closed 2 years ago

WardBrian commented 2 years ago

This runs stanc --print-canonical on all files. This removes a lot of deprecated syntax, in addition to auto-formatting all the code.

This is a draft because I am still looking it over myself and some changes to stanc3 are still being cleared to make the formatting prettier (https://github.com/stan-dev/stanc3/pull/970)

Fixes:

array[] syntax
Replaces <-
Replaces if_else
Replaces increment_log_prob
Fixes some names of functions, particularly the suffixes

Does not fix:

ODE solver changes

WardBrian commented 2 years ago

@rok-cesnovar I'm going to manually go through this PR now, searching primarily for // ^^^ comments and manually moving them to better positions. After that, want to scroll through as well to make sure it all looks reasonable here?

rok-cesnovar commented 2 years ago

Yeah, tag me once you think its good to go.

WardBrian commented 2 years ago

@rok-cesnovar I'm starting my manual comb through now (ran again with https://github.com/stan-dev/stanc3/pull/1055), unless I find anything obviously wrong I think this will be good to go.

WardBrian commented 2 years ago

Finally had the chance to scroll through the entire set of changes. All look good to me. I'd 'approve' if I could, but they don't let you do that as the author.

@rok-cesnovar if you get a chance to take a look please do!

rok-cesnovar commented 2 years ago

Wrote down as todo for tomorrow.