search

stan-dev / example-models

Example models for Stan
http://mc-stan.org/
766 stars 478 forks source link

Upload Causal IV case study in education folder #219

Closed joonho112 closed 9 months ago

joonho112 commented 10 months ago

Hello, I've uploaded a case study document titled "Instrumental Variables Analysis of Randomized Experiments with One-Sided Noncompliance." This study is a collaborative work with Profs. Avi Feller and Sophia Rabe-Hesketh from UC Berkeley. The document is a result of our work on the IES project, which you can review here: IES Project Link. I would greatly appreciate it if you could approve this merge request. Thank you.

andrjohns commented 10 months ago

Can you remove the two .DS_Store files and update the deprecated syntax in your Stan models?

@davkoh would you be able to review this one? You can see the rendered HTML at this link (it takes a second to load)

joonho112 commented 10 months ago

Hello @andrjohns, Thank you for your insights and guidance. I've updated the Stan code in accordance with your suggestions and removed the .DS_Store files. Please take a moment to review the modifications, and let me know if there are any additional adjustments needed prior to the publication of these files.

andrjohns commented 10 months ago

Hello @andrjohns, Thank you for your insights and guidance. I've updated the Stan code in accordance with your suggestions and removed the .DS_Store files. Please take a moment to review the modifications, and let me know if there are any additional adjustments needed prior to the publication of these files.

The CI (model compilation) is still failing because your Stan models are using the old array syntax which has been removed from Stan. See this section of the manual for guidance on how to update

joonho112 commented 10 months ago

I have updated all Stan models with the new array syntax.

joonho112 commented 9 months ago

I have made the necessary adjustments to the Stan code, transitioning the codes from the "transformed parameters" section to the "generated quantities" section. Additionally, I have removed all .DS_Store files from the repository.

Could you proceed to merge this Pull Request? I am looking forward to the final sign-off.

bob-carpenter commented 9 months ago

Thanks. Looks good. That label from GitHub that says they're -6kb is confusing, because they appear to have been deleted when I look at your branch. I can merge.