Closed ericnovik closed 7 years ago
Sorry for taking so long --- I forgot there were pull requests still here.
Looks good to me. But now there seems to be some kind of merge conflict.
@ericnovik, does your branch still exist?
Do we need it? I think this was merged.
On Fri, Sep 2, 2016 at 5:56 PM, Daniel Lee notifications@github.com wrote:
@ericnovik https://github.com/ericnovik, does your branch still exist?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stan-dev/example-models/pull/30#issuecomment-244496722, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMgfaIeW_jRlh6NhB1X6IRXvygBjCZpks5qmJukgaJpZM4FrVj8 .
It wasn't merged, but we can skip it. No harm if it's hard to find the branch.
On Sep 3, 2016, at 1:50 PM, Eric Novik notifications@github.com wrote:
Do we need it? I think this was merged.
On Fri, Sep 2, 2016 at 5:56 PM, Daniel Lee notifications@github.com wrote:
@ericnovik https://github.com/ericnovik, does your branch still exist?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stan-dev/example-models/pull/30#issuecomment-244496722, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMgfaIeW_jRlh6NhB1X6IRXvygBjCZpks5qmJukgaJpZM4FrVj8 .
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
At one point I merged a PR from Eric into example-models, is this something different?
On Saturday, September 3, 2016, Daniel Lee notifications@github.com wrote:
It wasn't merged, but we can skip it. No harm if it's hard to find the branch.
On Sep 3, 2016, at 1:50 PM, Eric Novik <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
Do we need it? I think this was merged.
On Fri, Sep 2, 2016 at 5:56 PM, Daniel Lee <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
@ericnovik https://github.com/ericnovik, does your branch still exist?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stan-dev/example-models/pull/30# issuecomment-244496722, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMgfaIeW_ jRlh6NhB1X6IRXvygBjCZpks5qmJukgaJpZM4FrVj8 .
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/stan-dev/example-models/pull/30#issuecomment-244574371, or mute the thread https://github.com/notifications/unsubscribe-auth/AHb4Q06xPGtfsTv87fVNp5S4LhYw_LBXks5qmfpHgaJpZM4FrVj8 .
@ericnovik Sorry that I completely forgot reviewing this whole repo. Looks like there are conflicts now. Do you want to clean this up or retract it?
I'm going to close this given that there hasn't been a response on cleaning up the conflicts.
Please, let me know if this is OK.