search

stan-dev / example-models

Example models for Stan
http://mc-stan.org/
771 stars 479 forks source link

Add baseball model from Doing Bayesian Data Analysis #89

Closed IamGianluca closed 7 years ago

IamGianluca commented 7 years ago

This Pull Request introduced the baseball.stan model from chapter 9 of Doing Bayesian Data Analysis. I received the approval from John Kruschke for publishing the Stan translated models into this repository.

As part of this Pull Request I've also attached two other models, named therapeutic_touch_bernoulli.stan and therapeutic_touch_binomial.stan. I haven't pushed the final version of the Jupyter notebook for this model yet, as I want to gather some feedback from the baseball one first.

I think a notebook like this could be greatly improved the readability of the model, especially for user with not much expertise in Bayesian Inference.

As I am myself learning Bayesian Inference while reading DBDA, I'm planning to make some further adjustments to the notebook in the future weeks.

bob-carpenter commented 7 years ago

Can you get that in writing or ask Krushcke to put some license on them, like BSD, that lets anyone use them for anything with attribution?

On Jan 23, 2017, at 4:54 PM, Gianluca Rossi notifications@github.com wrote:

This Pull Request introduced the baseball.stan model from chapter 9 of Doing Bayesian Data Analysis. I received the approval from John Kruschke for publishing the Stan translated models into this repository.

As part of this Pull Request I've also attached two other models, named therapeutic_touch_bernoulli.stan and therapeutic_touch_binomial.stan. I haven't pushed the final version of the Jupyter notebook for this model yet, as I want to gather some feedback from the baseball one first.

I think a notebook like this could be greatly improved the readability of the model, especially for user with not much expertise in Bayesian Inference.

As I am myself learning Bayesian Inference while reading DBDA, I'm planning to make some further adjustments to the notebook in the future weeks.

You can view, comment on, or merge this pull request online at:

https://github.com/stan-dev/example-models/pull/89

Commit Summary

• add baseball model File Changes

• M .gitignore (7) • A DBDA/README.md (35) • A DBDA/ch9/baseball.ipynb (1730) • A DBDA/ch9/baseball.stan (53) • A DBDA/ch9/data/BattingAverage.csv (949) • A DBDA/ch9/data/TherapeuticTouchData.csv (281) • A DBDA/ch9/therapeutic_touch_bernoulli.stan (34) • A DBDA/ch9/therapeutic_touch_binomial.stan (29) Patch Links:

• https://github.com/stan-dev/example-models/pull/89.patch • https://github.com/stan-dev/example-models/pull/89.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

IamGianluca commented 7 years ago

Hi Bob, I've just asked to John to comment on this Pull Request.

bob-carpenter commented 7 years ago

I just followed up, but I didn't have your email to cc you on the mail to John Kruschke. Hopefully he can just post licensing terms of the code he is distributing.

bob-carpenter commented 7 years ago

We can't merge this because we don't have permission to use Kruschke's code, so I'm closing.

IamGianluca commented 7 years ago

Thank you so much for the feedback Bob. I really appreciate it! I'm going to make the changes you suggested.

bob-carpenter commented 7 years ago

I'm happy to provide feedback for the models you write for the book even if they're not going on our site. Just let me know where they're at to comment.

On Jan 30, 2017, at 4:25 PM, Gianluca Rossi notifications@github.com wrote:

Thank you so much for the feedback Bob. I really appreciate it! I'm going to make the changes you suggested.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.