Closed WardBrian closed 2 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.2 | 0.2 | 0.98 | -2.01% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.02 | 2.44% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.05 | 4.69% faster |
gp_regr/gp_regr.stan | 0.11 | 0.11 | 1.0 | 0.03% faster |
sir/sir.stan | 78.29 | 76.49 | 1.02 | 2.3% faster |
irt_2pl/irt_2pl.stan | 3.88 | 3.8 | 1.02 | 2.01% faster |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.04 | 3.65% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.25 | 0.24 | 1.05 | 4.97% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.12 | 17.58 | 1.03 | 2.95% faster |
garch/garch.stan | 0.47 | 0.46 | 1.02 | 1.59% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.8 | 2.81 | 1.0 | -0.48% slower |
arK/arK.stan | 1.63 | 1.6 | 1.02 | 1.79% faster |
gp_pois_regr/gp_pois_regr.stan | 2.53 | 2.46 | 1.03 | 2.67% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.18 | 8.93 | 1.03 | 2.75% faster |
performance.compilation | 177.55 | 177.62 | 1.0 | -0.04% slower |
Mean result: 1.0202853553384719
Jenkins Console Log Blue Ocean Commit hash: ffae22a76851e3b49ca43f31234eeada692f1d9b
Summary
Originally reported on the forums
The error message for mismatching dimensions was pretty mangled. Previously, it could generate an error like:
After this change, it would instead be
Tests
Side Effects
Release notes
Improved error messages when variables dimensions do not match in operations that require it.
Checklist
[x] Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
[x] the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)[x] the code is written in idiomatic C++ and changes are documented in the doxygen
[] the new changes are tested