Closed andrjohns closed 5 months ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.19 | 0.18 | 1.05 | 4.55% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.02 | 1.5% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.07 | 6.34% faster |
gp_regr/gp_regr.stan | 0.11 | 0.1 | 1.05 | 4.71% faster |
sir/sir.stan | 79.36 | 76.37 | 1.04 | 3.78% faster |
irt_2pl/irt_2pl.stan | 3.75 | 3.97 | 0.94 | -5.91% slower |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 0.97 | -3.03% slower |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.24 | 0.25 | 0.97 | -3.28% slower |
pkpd/one_comp_mm_elim_abs.stan | 17.94 | 18.39 | 0.98 | -2.53% slower |
garch/garch.stan | 0.46 | 0.49 | 0.94 | -6.8% slower |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.78 | 2.83 | 0.98 | -2.04% slower |
arK/arK.stan | 1.63 | 1.66 | 0.99 | -1.49% slower |
gp_pois_regr/gp_pois_regr.stan | 2.5 | 2.59 | 0.96 | -3.86% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.12 | 9.23 | 0.99 | -1.22% slower |
performance.compilation | 174.42 | 174.34 | 1.0 | 0.05% faster |
Mean result: 0.9953760796350358
Jenkins Console Log Blue Ocean Commit hash: 13017193216fe150e9a8fadbc7b3f9cb71f8a58d
LGTM!
It still bothers me that we have different names for this than TBB (which uses only
TBB_INC
andTBB_LIB
)
Yeah, agreed
Summary
When using an external SUNDIALS library via the
SUNDIALS_TARGETS
variable added in #2861, Stan will still try to delete the library files when callingmake clean-all
.With
make/local
:Gives
clean-all
behaviour:This PR simply wraps the SUNDIALS build and clean rules in an
ifndef
, so that they are ignored whenSUNDIALS_TARGETS
is specifiedTests
N/A
Side Effects
N/A
Release notes
Fixed
clean-all
error when using external SUNDIALS librariesChecklist
[x] Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
[x] the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)[x] the code is written in idiomatic C++ and changes are documented in the doxygen
[x] the new changes are tested