Open andrjohns opened 1 month ago
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.19 | 0.24 | 0.79 | -26.4% slower |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 1.08 | 7.39% faster |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.04 | 3.45% faster |
gp_regr/gp_regr.stan | 0.11 | 0.1 | 1.04 | 3.85% faster |
sir/sir.stan | 76.81 | 74.57 | 1.03 | 2.92% faster |
irt_2pl/irt_2pl.stan | 3.85 | 3.76 | 1.02 | 2.4% faster |
eight_schools/eight_schools.stan | 0.05 | 0.05 | 1.04 | 3.93% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.32 | 0.24 | 1.32 | 24.11% faster |
pkpd/one_comp_mm_elim_abs.stan | 18.0 | 17.61 | 1.02 | 2.21% faster |
garch/garch.stan | 0.45 | 0.44 | 1.02 | 2.32% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.78 | 2.73 | 1.02 | 1.9% faster |
arK/arK.stan | 1.63 | 1.58 | 1.03 | 3.0% faster |
gp_pois_regr/gp_pois_regr.stan | 2.51 | 2.49 | 1.01 | 0.93% faster |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.15 | 8.89 | 1.03 | 2.89% faster |
performance.compilation | 173.63 | 176.2 | 0.99 | -1.48% slower |
Mean result: 1.0320695198409306
Jenkins Console Log Blue Ocean Commit hash: 13017193216fe150e9a8fadbc7b3f9cb71f8a58d
Name | Old Result | New Result | Ratio | Performance change( 1 - new / old ) |
---|---|---|---|---|
arma/arma.stan | 0.23 | 0.22 | 1.05 | 4.56% faster |
low_dim_corr_gauss/low_dim_corr_gauss.stan | 0.01 | 0.01 | 0.98 | -1.58% slower |
gp_regr/gen_gp_data.stan | 0.02 | 0.02 | 1.07 | 6.18% faster |
gp_regr/gp_regr.stan | 0.12 | 0.11 | 1.04 | 3.42% faster |
sir/sir.stan | 84.87 | 83.21 | 1.02 | 1.96% faster |
irt_2pl/irt_2pl.stan | 4.5 | 4.73 | 0.95 | -4.98% slower |
eight_schools/eight_schools.stan | 0.06 | 0.06 | 1.05 | 4.94% faster |
pkpd/sim_one_comp_mm_elim_abs.stan | 0.27 | 0.27 | 1.03 | 2.78% faster |
pkpd/one_comp_mm_elim_abs.stan | 19.73 | 20.2 | 0.98 | -2.36% slower |
garch/garch.stan | 0.53 | 0.51 | 1.03 | 2.62% faster |
low_dim_gauss_mix/low_dim_gauss_mix.stan | 2.99 | 3.24 | 0.92 | -8.26% slower |
arK/arK.stan | 1.73 | 1.88 | 0.92 | -8.53% slower |
gp_pois_regr/gp_pois_regr.stan | 2.73 | 2.92 | 0.94 | -6.83% slower |
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan | 9.77 | 9.89 | 0.99 | -1.28% slower |
performance.compilation | 192.19 | 199.63 | 0.96 | -3.87% slower |
Mean result: 0.9947758466913733
Jenkins Console Log Blue Ocean Commit hash: 13017193216fe150e9a8fadbc7b3f9cb71f8a58d
Summary
As discussed over in #2951, it would be useful to be able to iterate over nested containers and multiple arguments.
This PR extends
scalar_seq_view
to work withstd::vector<Container>
andstd::tuple<T...>
types, allowing for indexing them like a single sequence of scalars.Tests
Tests added for checking the correctness of reading and assigning values with the new overloads
Side Effects
N/A
Release notes
Expanded
scalar_seq_view
to work with nested containers and tuplesChecklist
[x] Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
[x] the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)[x] the code is written in idiomatic C++ and changes are documented in the doxygen
[x] the new changes are tested