search

stan-dev / math

The Stan Math Library is a C++ template library for automatic differentiation of any order using forward, reverse, and mixed modes. It includes a range of built-in functions for probabilistic modeling, linear algebra, and equation solving.
https://mc-stan.org
BSD 3-Clause "New" or "Revised" License
738 stars 186 forks source link

Reconsider Makefile including config from `$HOME` #3088

Closed WardBrian closed 3 months ago

WardBrian commented 3 months ago

Description

Stan's makefiles include custom configuration from a couple locations.

The first is make/local, and this is what we document and recommend using.

The second is a sub-directory of $HOME: https://github.com/stan-dev/math/blob/4c626fddcdaba37c988190f805b2fff3f80e80dc/makefile#L14

This can cause issues when HOME has a space in the path (found by @andrjohns)

I don't think we document this file anywhere, and I also think that allowing a global config like this is probably a bad idea in general.

Current Version:

v4.9.0

SteveBronder commented 3 months ago

idk anyone that uses this so I'm pretty for removing it