search

stan-dev / posterior

The posterior R package
https://mc-stan.org/posterior/
Other
167 stars 24 forks source link

checkmate::expect_numeric requires testthat (but is not a dependency of posterior) #329

Closed n-kall closed 11 months ago

n-kall commented 11 months ago

The internal validate_weights function uses checkmate::expect_numeric (see here) and checkmate::expect_flag which require testthat but it is only in suggests. I think a fix would be to change this to checkmate::assert_numeric and checkmate::assert_flag.

n-kall commented 11 months ago

Also the same issue in pareto_smooth (see here)

paul-buerkner commented 11 months ago

Thanks! would you be able to make the necessary changes in a PR?

n-kall commented 11 months ago

Sure. I'll fix it shortly