Closed n-kall closed 6 months ago
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 86c8fba71b1be6cf01e847cb7901fd384ab4fa2b is merged into master:
Looks good to me. Do you want to make any changes before I merge?
I think it's ready
great! Merging now. Thank you!
Summary
This changes
pareto_*
functions to no longer return named numeric values if there is just a single value output. This applies topareto_khat
,pareto_khat_threshold
,pareto_min_ss
, andpareto_convergence_rate
.pareto_diags
returns a named vector of all of these. Andpareto_smooth
is not affected by this.This also changes the return type of
pareto_khat
to be an unnamed numeric rather than a list, which would require a change in loo (specifically E_loo). As there is already an issue that needed to be worked around (stan-dev/loo/issues/263) I think this is worth addressing now.This would close #359 and #346
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: