eerolinna commented 4 years ago

I added the model under the namespace pymc3 as pymc4 is coming at some point with a different API. Related to #117

codecov-io commented 4 years ago

Codecov Report

Merging #118 into master will increase coverage by 4.35%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #118      +/-   ##
=========================================
+ Coverage   94.94%   99.3%   +4.35%     
=========================================
  Files          22       6      -16     
  Lines         693     144     -549     
=========================================
- Hits          658     143     -515     
+ Misses         35       1      -34

Impacted Files	Coverage Δ
rpackage/R/gold_standard.R
rpackage/R/filter.R
rpackage/R/check_pdb.R
rpackage/R/data_info.R
rpackage/R/utils_gold_standard.R
rpackage/R/write_pdb.R
rpackage/R/remove_pdb.R
rpackage/R/utils_tests.R
rpackage/R/tibble.R
rpackage/R/posterior.R
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3de8700...9e3a14d. Read the comment docs.

eerolinna commented 4 years ago

Looks like the R tests currently don't allow anything else than stan as slots of model_code, this is why the tests fail.

Assertion on 'names(x$model_code)' failed: Must be a subset of set {stan}.

MansMeg commented 4 years ago

Yes. I will fix this. Can you do a PR to the branch development, then I can fix it and then merge to master?

eerolinna commented 4 years ago

Sure, it's in PR #119 now. However there are also alternative ways to achieve the same goal that I'll show here just in case you don't know about them yet / haven't thought of them.

You can add commits directly to this PR. Here's instructions on how to do that https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

You could also create a separate PR to master that fixes the tests and then merge this after that one is complete.

If you prefer to just merge this to development see PR #119

stan-dev / posteriordb

Add pymc3 eight schools model #118

Codecov Report