search

stan-dev / posteriordb

Database with posteriors of interest for Bayesian inference
176 stars 36 forks source link

Deleted _MACOSX folders from kidiq.json.zip and kidiq_with_mom_work.j… #155

Closed jarnefeltoliver closed 4 years ago

jarnefeltoliver commented 4 years ago

…son.zip and modified the python README.md

codecov-io commented 4 years ago

Codecov Report

Merging #155 into development will decrease coverage by 4.17%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #155      +/-   ##
===============================================
- Coverage        79.24%   75.06%   -4.18%     
===============================================
  Files               18       18              
  Lines              718      718              
===============================================
- Hits               569      539      -30     
- Misses             149      179      +30
Impacted Files Coverage Δ
rpackage/R/pdb_github.R 47.36% <0.00%> (-38.16%) :arrow_down:
rpackage/R/check_pdb.R 95.45% <0.00%> (-4.55%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 190979c...97c321a. Read the comment docs.

eerolinna commented 4 years ago

Hey, regarding the python readme modifications, as far as I understand using setup.py directly is not recommended. Using pip install . or python -m pip install . would be better.

eerolinna commented 4 years ago

Can you change the readme to use one of these?

jarnefeltoliver commented 4 years ago

Done. Now reads: from main directory run pip install python/

eerolinna commented 4 years ago

Thanks!