search

stan-dev / posteriordb

Database with posteriors of interest for Bayesian inference
181 stars 36 forks source link

Load json with utf-8 encoding #185

Closed ahartikainen closed 4 years ago

ahartikainen commented 4 years ago

This fixes the error with special characters.

I think the default encoding on Windows is not utf-8 which might cause this problem where special characters have wrong char.

MansMeg commented 4 years ago

Thank you for the response! Ive been on vacation so I have not been very fast to respond.

I think linux and mac is using utf-8 as default? I'm hesitant to use Windows as a standard since that is a minority of users, I think? Or what do you say?

ahartikainen commented 4 years ago

Yes, linux and macOS are probably utf-8 by default.

But your files are encoded as utf-8, so you should decode them as utf-8, not with system defaults.

MansMeg commented 4 years ago

Ah! Yes of course!

MansMeg commented 4 years ago

This is great! Now merged.