search

stan-dev / posteriordb

Database with posteriors of interest for Bayesian inference
161 stars 26 forks source link

Update CONTRIBUTING.md #234

Closed bob-carpenter closed 3 years ago

bob-carpenter commented 3 years ago

I fixed spelling of BSD and tried to clarify that users could specify alternative open-source licenses.

I think it would help to clarify which alternative licenses are acceptable. If the package consists of a mix of copyleft (GPL) and more liberal (BSD, etc.) licenses, that makes the project maximally difficult to import into other projects. I would strongly urge rethinking this and insisting on BSD, or at least insisting on non-copyleft licenses that are at least GPLv3 compatible.

bob-carpenter commented 3 years ago

I didn't mean to kick off expensive unit tests for fixing a typo. As tempted as I am to just merge, I'll let it finish to follow process. I'm a bit shocked by the fact that the Stan project is now spending over $3K/month on AWS charges for all this continuous integration testing.

Now one of the R tests failed. This is bad because I only fixed a typo in a .md document.

MansMeg commented 3 years ago

Hi! Yes, this is my fault. I will fix this. I'm a little too defensive in the testings. A bad habit...