stan-dev / posteriordb

Database with posteriors of interest for Bayesian inference
161 stars 26 forks source link

New stan syntax and tags #253

Closed MansMeg closed 8 months ago

MansMeg commented 9 months ago

The PR includes:

paul-buerkner commented 9 months ago

I am afraid I won't have the time for full code checking at the moment. Is there something you would like me to take a look at specificially?

MansMeg commented 9 months ago

Sorry for my late reply. I updated all the syntax using the stance compiler and checked that all models works to compile and run so I would just skim through quickly and see if you see anything crazy.

I also polished the tags based on discussion with aki to formalize that a little more. You can see the keywords here: doc/KEYWORDS.md That might be good to get extra eyes on.

We have also discussed better ways to assess convergence for reference posteriors (that are less hacky) in: doc/REFERENCE_POSTERIOR_DEFINITION.md That might also be good to just look through.

paul-buerkner commented 9 months ago

I am currently super busy with teaching and grant writing. If you want to merge it this or next week, perhaps already merge without my feedback. Sorry for being so slow with this right now :-(

MansMeg commented 8 months ago

No problem @paul-buerkner . Maybe @avehtari could take a quick look if something is missing.